[PATCH] D27135: [CMAKE] fix LLVM_OPTIMIZED_TABLEGEN for Visual Studio

[Daniil Fukalov via Phabricator via llvm-commits]

dfukalov marked an inline comment as done.
dfukalov added inline comments.


================
Comment at: CMakeLists.txt:532
 option(LLVM_OPTIMIZED_TABLEGEN "Force TableGen to be built with optimization" OFF)
-if(CMAKE_CROSSCOMPILING OR (LLVM_OPTIMIZED_TABLEGEN AND LLVM_ENABLE_ASSERTIONS))
+if(CMAKE_CROSSCOMPILING OR (LLVM_OPTIMIZED_TABLEGEN AND (LLVM_ENABLE_ASSERTIONS OR MSVC_IDE)))
   set(LLVM_USE_HOST_TOOLS ON)
----------------
beanz wrote:
> Rather than `OR MSVC_IDE` maybe use `OR CMAKE_CONFIGURATION_TYPES`, that would make this work for all multi-configuration generators.
good point, thanks!


https://reviews.llvm.org/D27135