[PATCH] D27158: Use relocations to fill statically known got entries

[Peter Smith via Phabricator via llvm-commits]

peter.smith added inline comments.


================
Comment at: lld/ELF/Target.cpp:1699
   case R_ARM_TLS_LDO32:
   case R_ARM_TLS_LE32:
+  case R_ARM_GLOB_DAT:
----------------
For ARM (and Mips if it were to use this mechanism) I think we are missing the Target::moduleIndexRel R_ARM_TLS_DTPMOD32 (Always resolves to 1 for an executable). This is currently not showing up in the tests as for ARM as the current implementation forces TLS to use dynamic relocations, but will need to be fixed for static linking. The handleNoRelaxTlsRelocation will most likely need to generate this. I think this could be added in a later patch though.


https://reviews.llvm.org/D27158