[PATCH] D27044: Compilation crash after node replacement

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 27 08:54:17 PST 2016


spatel added a comment.

I haven't looked at this level of the DAG very much, so I'm not the best reviewer for the patch. 
But if it's valid to specialize the one-use case, then can we just add a 'hasOneUse()' check to the existing ReplaceAllUsesWith() instead of adding another function call? That way, all callers of ReplaceAllUsesWith() would benefit. Or is there some other difference that triggers the bug that we're trying to avoid?


Repository:
  rL LLVM

https://reviews.llvm.org/D27044





More information about the llvm-commits mailing list