[PATCH] D26895: [X86][LMT] Restrict nop length to one

[Amjad Aboud via Phabricator via llvm-commits]

aaboud added a comment.

Look good to me



================
Comment at: lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp:84
               CPU != "geode" && CPU != "winchip-c6" && CPU != "winchip2" &&
-              CPU != "c3" && CPU != "c3-2";
+              CPU != "c3" && CPU != "c3-2" && CPU != "lakemont";
   }
----------------
Maybe it worth adding a comment here explaining why you are preventing generating long nops for lakemont.


================
Comment at: test/MC/X86/x86_long_nop.s:19-20
 
-# On Silvermont and Lakemont we emit only 7 byte NOPs since longer NOPs
+# On Silvermont we emit only 7 byte NOPs since longer NOPs
 # are not profitable.
 # LNOP7: 0:  inc
----------------
You may fit the comment in one line now, it will be still less than 80 characters.


Repository:
  rL LLVM

https://reviews.llvm.org/D26895