[PATCH] D27145: Add "RPRED" mechanism for relocation predicates. (5% speedup for `ld.lld -O0`)

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

4% speedup in -O1 sounds like a nice improvement.



================
Comment at: ELF/Relocations.def:21-23
+PREDICATE(RPRED_ALWAYS_CONSTANT, 1)
+PREDICATE(RPRED_REFERS_TO_GOT, 2)
+PREDICATE(RPRED_RELAX_MARKER, 3)
----------------
Are these numbers correct? It seems that

  PRED_RELAX_MARKER == PRED_ALWAYS_CONSTANT | PRED_REFERS_TO_GOT

holds, which is odd. Don't you need power-of-twos?


https://reviews.llvm.org/D27145