[PATCH] D27097: [ELF] Refactor target errors

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.


================
Comment at: ELF/Writer.cpp:1559
+
+  for (OutputSectionBase *S : OutputSections) {
+    uint8_t *OutSecLoc = Start + S->Offset;
----------------
ruiu wrote:
> I think we should make OutputSections global, instead of doing a plumbing work to propagate information from Target to Writer.
How about Buffer pointer? It isn't stored in OutputSection<ELFT>.
What do you think about saving buffer position in OutputSection<ELFT> and iterating over Symtab<ELFT>::Sections, instead of OutputSections ?


Repository:
  rL LLVM

https://reviews.llvm.org/D27097