[PATCH] D23630: [PPC] Expand ISEL instruction into if-then-else sequence

[Nemanja Ivanovic via llvm-commits]

nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCExpandISEL.cpp:225
+  // Special case 2, the two input registers used by ISEL are the same.
+  if (TrueValue.getReg() == FalseValue.getReg()) {
+    DEBUG(dbgs() << "Fold the ISEL insturction to an unconditonal copy.");
----------------
kbarton wrote:
> This should be done earlier, especially before (possibly) creating the NewSuccessor basic block above. 
> I would move this as early as possible, once all the information needed is available. 
Yes, I'd handle the cases where you're getting rid of the ISEL without introducing new control flow first - i.e. before you start creating new control flow.


https://reviews.llvm.org/D23630