[PATCH] D27094: [StringRef] Use default member initializers and = default.

Malcolm Parsons via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 24 04:34:11 PST 2016


malcolm.parsons updated this revision to Diff 79216.
malcolm.parsons added a comment.

Upload the correct patch.


https://reviews.llvm.org/D27094

Files:
  include/llvm/ADT/StringRef.h


Index: include/llvm/ADT/StringRef.h
===================================================================
--- include/llvm/ADT/StringRef.h
+++ include/llvm/ADT/StringRef.h
@@ -53,10 +53,10 @@
 
   private:
     /// The start of the string, in an external buffer.
-    const char *Data;
+    const char *Data = nullptr;
 
     /// The length of the string.
-    size_t Length;
+    size_t Length = 0;
 
     // Workaround memcmp issue with null pointers (undefined behavior)
     // by providing a specialized version
@@ -71,7 +71,7 @@
     /// @{
 
     /// Construct an empty string ref.
-    /*implicit*/ StringRef() : Data(nullptr), Length(0) {}
+    /*implicit*/ StringRef() = default;
 
     /// Disable conversion from nullptr.  This prevents things like
     /// if (S == nullptr)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27094.79216.patch
Type: text/x-patch
Size: 786 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161124/61492c95/attachment.bin>


More information about the llvm-commits mailing list