[PATCH] D27070: Implement STARTUP linker script command.

[George Rimar via llvm-commits]

grimar added inline comments.


================
Comment at: test/ELF/linkerscript/startup.s:4
+# RUN: mkdir -p %t.dir
+# RUN: cd %t.dir
+
----------------
grimar wrote:
> This creates "startup.s.tmp.dir" folder for me inside tools\lld\test\ELF\linkerscript\Output.
> And looks that is the only folder inside at this moment.
> So out tests previously did not do that and that is inconsistency.
> 
> Do you plan to do that for all tests ?
I think I had to clarify why I noticed that. Usually I use msvs output tab to extract command line with arguments of failing test.

When test uses %t (like all out test do), line is something like:

> 23>  $ "C:/access_softek/c_make_build_dir/Debug/bin\ld.lld.EXE" "--full-shutdown" "C:\xxx\tools\lld\test\ELF\Output\eh-frame-merge.s.tmp.o" "C:\xxx\tools\lld\test\ELF\Output\eh-frame-merge.s.tmp.o" "-o" "C:\xxx\tools\lld\test\ELF\Output\eh-frame-merge.s.tmp" "-shared"

So I can just copy it to MSVS property page to "command arguments" and use it for debugger.

This test is different and does not use %t and creates local files in separate folder.
Line for it is:

> 23>  C:/xxx/Debug/bin\ld.lld.EXE --full-shutdown -o exe -script=script foo.o bar.o

So I also need to set "working directory" property. 
What is not a huge problem but a bit less convinent. Especially when one test do that and other - not.


https://reviews.llvm.org/D27070