[PATCH] D27055: [ELF] Refactor getDynRel to print error location

[Eugene Leviant via llvm-commits]

evgeny777 added inline comments.


================
Comment at: ELF/Target.h:29-31
+  virtual std::pair<uint32_t, bool> getDynRel(uint32_t Type) const {
+    return {Type, true};
+  }
----------------
ruiu wrote:
> The meaning of the second return value is not very clear. How about this? We can add `Target::isAbsRel(uint32_t)`. If it returns true, we should report an error. Then I think we don't need to modify getDynRel.
isAbsRel is a bit confusing (in position independent code RelExpr may be R_GOT_PC as well). How about isPICRel ?


Repository:
  rL LLVM

https://reviews.llvm.org/D27055