[PATCH] D27077: LTO: Port the new LTO API to ModuleSymbolTable.

[Mehdi AMINI via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/LTO/LTO.h:166
+           const ModuleSymbolTable *SymTab, const InputFile *File)
+        : I(I), SymTab(SymTab), File(File) {
       skip();
----------------
Can you turn SymTab and File to be reference?


================
Comment at: llvm/include/llvm/LTO/LTO.h:171
     StringRef getName() const { return Name; }
     StringRef getIRName() const {
+      if (isGV())
----------------
Non relevant for this patch, but it'd be nice to document getName vs getIRName, I always forget when I look at this.


================
Comment at: llvm/include/llvm/LTO/LTO.h:248
 
-  StringRef getSourceFileName() const {
-    return Obj->getModule().getSourceFileName();
-  }
-
-  MemoryBufferRef getMemoryBufferRef() const {
-    return Obj->getMemoryBufferRef();
-  }
+  StringRef getSourceFileName() const { return Mod->getSourceFileName(); }
+  MemoryBufferRef getMemoryBufferRef() const { return MBRef; }
----------------
Looks like something to add to `ModuleSymbolTable`.
(I don't mean it as a blocker for this patch)


https://reviews.llvm.org/D27077