[PATCH] D26778: Add llvm-modextract tool.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 20:55:27 PST 2016


Agreed that this would be a nice future improvement. Now that we have
subcommand support in llvm::cl we presumably (haven't looked closely) have
a clean way to do it. I just would prefer it not to be done with
overlapping llvm::cl arguments in a single tool.

Peter

On Nov 23, 2016 20:45, "Sean Silva" <chisophugis at gmail.com> wrote:

>
>
> On Wed, Nov 23, 2016 at 8:29 PM, Peter Collingbourne <peter at pcc.me.uk>
> wrote:
>
>> I also considered doing that but I felt that it would make the control
>> flow inside that tool awkward. Basically we would have one code path for
>> extracting a module and another for everything else.
>>
>
> Fair enough. The llvm-bcutil idea I mentioned in D26179 could make it a
> bit less awkward, as then they would just be separate subcommands (sort of
> analogous to yaml2obj's top-level switching on the format). We are already
> growing a significant number of miscellaneous tiny utilities for testing
> various API's, so it might be nice to unify them one day, but it's not a
> big deal.
>
> -- Sean Silva
>
>
>> Peter
>>
>> On Nov 23, 2016 20:21, "Mehdi AMINI" <mehdi.amini at apple.com> wrote:
>>
>>> mehdi_amini added a comment.
>>>
>>> I agree with Sean! Reusing llvm-extract seems appropriate to me here.
>>>
>>>
>>> https://reviews.llvm.org/D26778
>>>
>>>
>>>
>>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161123/008b3444/attachment.html>


More information about the llvm-commits mailing list