[PATCH] D27075: Object: Add SF_Text symbol flag.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 19:56:10 PST 2016


pcc added inline comments.


================
Comment at: llvm/lib/Object/ModuleSymbolTable.cpp:166
+    if (isa<Function>(GO) && !GO->hasSection())
+      Res |= BasicSymbolRef::SF_Text;
   if (GV->hasPrivateLinkage())
----------------
mehdi_amini wrote:
> Why the test on the presence of a section? Do we have a test that exercise this?
It's a rough approximation for "is this function in the .text section or not". I don't think there's a test, I'll add one.


https://reviews.llvm.org/D27075





More information about the llvm-commits mailing list