[PATCH] D27071: Add the ability to get a signed integer attribute from a DWARFDebugInfoEntry.

[David Blaikie via llvm-commits]

dblaikie added a comment.

> Trying to keep things smaller. This will be needed by an upcoming DWARF generator patch, but this is small and self contained.

I /really/ appreciate the effort to keep patches small - it helps everyone (faster to review (good for you and reviewers), easier to revert or investigate when looking for regressions, etc). But the converse of that - is that we don't generally commit dead code (that's why it's great to find an existing use case that could be improved by a refactoring/introduction of a new piece of functionality, etc).

If there's an existing piece of the codebase that could benefit from this API (reduce code duplication, etc) that you could add such a use to this patch, it'd be great to review/commit it separately like this, otherwise it may have to be grouped with anotehr commit - or at least a unit test?


https://reviews.llvm.org/D27071