[PATCH] D23652: [mips] N64 static relocation model support

[Joerg Sonnenberger via llvm-commits]

joerg added inline comments.


================
Comment at: lib/Target/Mips/MipsISelLowering.cpp:3693
 unsigned MipsTargetLowering::getJumpTableEncoding() const {
-  if (ABI.IsN64())
+  if (ABI.IsN64() && isPositionIndependent())
     return MachineJumpTableInfo::EK_GPRel64BlockAddress;
----------------
Please leave this alone. The trade-off is intentional and should stay. If anything, it should be further refined to default to EK_GPRel32BlockAddress, but it should certainly not use absolute labels.


https://reviews.llvm.org/D23652