[PATCH] D24956: [SelectionDAG] Add expansion and promotion of [US]MUL_LOHI

Nicolai Hähnle via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 13:11:48 PST 2016


nhaehnle updated this revision to Diff 79142.
nhaehnle added a comment.

Thank you for taking a look.

https://reviews.llvm.org/D26628 does not directly interact, since it affected a custom sequence used
by DAGTypeLegalizer if the call to TargetLowering has failed.  I suppose now
that TargetLowering no longer insists on only using legal instructions one
could think about using that mode instead of the custom sequence in
DAGTypeLegalizer, but that sequence is also qualitatively different (using a
regular NxN-bit multiply on values where everything but the low N/2 bits
have been masked out).

I've addressed your minor comments and split this up into three patches,
the first two being https://reviews.llvm.org/D27063 and https://reviews.llvm.org/D27064.

I'm going to add them as dependencies as well.  Unfortunately, handling
patch series with Phabricator seems really awkward :(


https://reviews.llvm.org/D24956

Files:
  include/llvm/Target/TargetLowering.h
  lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
  lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp
  lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp
  lib/CodeGen/SelectionDAG/TargetLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D24956.79142.patch
Type: text/x-patch
Size: 14150 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161123/06e32ad5/attachment.bin>


More information about the llvm-commits mailing list