[PATCH] D26943: [CodingStandards] Add style guide rule about "if" statements and loops.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 12:14:03 PST 2016


jlebar added a comment.

> Does it need to be codified in full?

I think we stand to benefit greatly from having an unambiguous statement of the rules, yes.

The cost of not having such a statement is that each reviewer has their own set of rules in their head, and so we waste human time during reviews with reviewers explaining their mental model and asking reviewees to change their code.  And that's in the best case, where the reviewees don't argue back.


https://reviews.llvm.org/D26943





More information about the llvm-commits mailing list