[llvm] r287786 - llvm-readobj: Use hash tables to print dynamic symbols.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 11:55:31 PST 2016


On Wed, Nov 23, 2016 at 11:48 AM, Hemant Kulkarni
<khemant at codeaurora.org> wrote:
>>Is this actually compatible with what the GNU tools emit? If so, fine (but could've >been mentioned in the commit message, I think). If not, I don't see why you >need to implement this in the GNU mode and not in readobj "default" mode. >Does this make sense?
>
> Good point. Yes it is compatible to what GNU readelf does. This only changes the order in which the symbols are printed  as per buckets and chains in hash.
>
> Do you want me to have this implemented in LLVM style?

I personally wouldn't mind (as it gives us additional validation in
the general case) but I'd rather discuss this more with the
people who touched the code over the last years.
Please note that this is very likely to break a ton of tests
in tools/ and lld/ELF, so I wouldn't change all them without
consensus. Maybe post a code review and see what others think?


-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare


More information about the llvm-commits mailing list