[llvm] r287800 - [LoopUnroll] Move code to exit early. NFC.
Haicheng Wu via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 23 11:39:26 PST 2016
Author: haicheng
Date: Wed Nov 23 13:39:26 2016
New Revision: 287800
URL: http://llvm.org/viewvc/llvm-project?rev=287800&view=rev
Log:
[LoopUnroll] Move code to exit early. NFC.
Just to save some compilation time.
Differential Revision: https://reviews.llvm.org/D26784
Modified:
llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
Modified: llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp?rev=287800&r1=287799&r2=287800&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/LoopUnrollPass.cpp Wed Nov 23 13:39:26 2016
@@ -948,7 +948,11 @@ static bool tryToUnrollLoop(Loop *L, Dom
Optional<bool> ProvidedUpperBound) {
DEBUG(dbgs() << "Loop Unroll: F[" << L->getHeader()->getParent()->getName()
<< "] Loop %" << L->getHeader()->getName() << "\n");
- if (HasUnrollDisablePragma(L)) {
+ if (HasUnrollDisablePragma(L))
+ return false;
+ if (!L->isLoopSimplifyForm()) {
+ DEBUG(
+ dbgs() << " Not unrolling loop which is not in loop-simplify form.\n");
return false;
}
@@ -958,6 +962,9 @@ static bool tryToUnrollLoop(Loop *L, Dom
TargetTransformInfo::UnrollingPreferences UP = gatherUnrollingPreferences(
L, TTI, ProvidedThreshold, ProvidedCount, ProvidedAllowPartial,
ProvidedRuntime, ProvidedUpperBound);
+ // Exit early if unrolling is disabled.
+ if (UP.Threshold == 0 && (!UP.Partial || UP.PartialThreshold == 0))
+ return false;
unsigned LoopSize = ApproximateLoopSize(
L, NumInlineCandidates, NotDuplicatable, Convergent, TTI, &AC, UP.BEInsns);
DEBUG(dbgs() << " Loop Size = " << LoopSize << "\n");
@@ -970,11 +977,6 @@ static bool tryToUnrollLoop(Loop *L, Dom
DEBUG(dbgs() << " Not unrolling loop with inlinable calls.\n");
return false;
}
- if (!L->isLoopSimplifyForm()) {
- DEBUG(
- dbgs() << " Not unrolling loop which is not in loop-simplify form.\n");
- return false;
- }
// Find trip count and trip multiple if count is not available
unsigned TripCount = 0;
@@ -991,10 +993,6 @@ static bool tryToUnrollLoop(Loop *L, Dom
TripMultiple = SE->getSmallConstantTripMultiple(L, ExitingBlock);
}
- // Exit early if unrolling is disabled.
- if (UP.Threshold == 0 && (!UP.Partial || UP.PartialThreshold == 0))
- return false;
-
// If the loop contains a convergent operation, the prelude we'd add
// to do the first few instructions before we hit the unrolled loop
// is unsafe -- it adds a control-flow dependency to the convergent
More information about the llvm-commits
mailing list