[PATCH] D27061: [asan] Avoid duplicate and redundant poisoning checks in __sanitizer_contiguous_container_find_bad_address

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 11:18:22 PST 2016


vitalybuka added a comment.

Could you please also update some test to cover new behavior?



================
Comment at: lib/asan/asan_poisoning.cc:423
       return reinterpret_cast<const void *>(i);
   for (uptr i = r2_beg; i < mid; i++)
     if (AddressIsPoisoned(i))
----------------
Could you please combine these
for (uptr i = r2_beg; i < mid; i++)
for (uptr i = mid; i < r2_end; i++)

into
for (uptr i = r2_beg; i < r2_end; i++)


Repository:
  rL LLVM

https://reviews.llvm.org/D27061





More information about the llvm-commits mailing list