[PATCH] D27036: [ELF][MIPS] Fix handling of _gp/_gp_disp/__gnu_local_gp symbols

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 10:59:12 PST 2016


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SyntheticSections.h:125
 
+  unsigned getGP() const;
+
----------------
nit: getGp for consistency.


================
Comment at: ELF/Writer.cpp:1421
+    ElfSym<ELFT>::MipsGpDisp->Value =
+        In<ELFT>::MipsGot->getGP() - In<ELFT>::MipsGot->getVA();
+  if (ElfSym<ELFT>::MipsLocalGp)
----------------
Compute this value only once.


Repository:
  rL LLVM

https://reviews.llvm.org/D27036





More information about the llvm-commits mailing list