[PATCH] D27052: [compiler-rt][asan] Fix overlaping parameters for memmove/memcpy on windows.

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 10:09:51 PST 2016


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

It seems like on Mac, memcpy == memmove since 10.6, which is so old, I would support a follow-up change to remove this logic:

  bool PlatformHasDifferentMemcpyAndMemmove() {
    // On OS X 10.7 memcpy() and memmove() are both resolved
    // into memmove$VARIANT$sse42.
    // See also https://github.com/google/sanitizers/issues/34.
    // TODO(glider): need to check dynamically that memcpy() and memmove() are
    // actually the same function.
    return GetMacosVersion() == MACOS_VERSION_SNOW_LEOPARD;
  }


https://reviews.llvm.org/D27052





More information about the llvm-commits mailing list