[PATCH] D26367: Fix DAGCombiner match
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 23 04:03:02 PST 2016
RKSimon added reviewers: rengolin, jmolloy.
RKSimon added a comment.
In https://reviews.llvm.org/D26367#599175, @evstupac wrote:
> >> This LGTM but I think we should probably add tests for other targets as well.
>
> There are similar tests on ARM only. When I tried to extend them I've got the following:
>
> ldrb r12, [lr, r12]!
> ldrb lr, [lr, #1]
>
>
> Instead of 1 ldrh.
>
> I'm not sure what is more profitable for ARM and which -mtriple/-mcpu is better. So I'd better leave the test inserting for ARM guys.
Renato/James - is there any insight you can offer here please?
Repository:
rL LLVM
https://reviews.llvm.org/D26367
More information about the llvm-commits
mailing list