[PATCH] D26869: [LV] Add flag for ignoring target info

[Michael Kuperstein via llvm-commits]

mkuper added a comment.

In https://reviews.llvm.org/D26869#603890, @anemet wrote:

> Hi Matt,
>
> You should probably circulate this more widely on llvm-dev.  This is a new policy on how one should write tests going under test/Transform/LoopVectorize.
>
> Thanks,
> Adam


It's more of a bugfix in the current policy - we used to have "target independent" tests because providing a manual UF and VF would, in effect, mean we'd make no cost model queries that affect the output. That was basically dumb luck - conceptually, tests for passes that rely on TTI need to either specify a target, or somehow be forced to be target-independent.

But I agree, it may be worth circulating more widely, since this problem probably exists outside the LV vectorizer, so we may want a more principled way to do it.

Do you have an opinion on the concept itself, other than "circulate more widely"?


https://reviews.llvm.org/D26869