[PATCH] D26811: [MemCpyOpt] Don't sink LoadInst below possible clobber.

[Amaury SECHET via llvm-commits]

deadalnix added a comment.

In https://reviews.llvm.org/D26811#603131, @efriedma wrote:

> LGTM with the testcase fixed... but please don't commit changes to this code unless you're intending to write a followup which actually makes it useful.  (If you're going to leave it in its current state, we might as well just delete it.)


What makes you think this isn't useful and should be deleted ? This is the only thing that can do load/store forwarding in the codebase when aggregates contains padding, so this ends up being important. I think it is very much worth committing.

However, if you have a better alternative to suggest, please do, I can even probably spend some time on it. Improving aggregates support is important to me a several other non clang front end devs.


Repository:
  rL LLVM

https://reviews.llvm.org/D26811