[PATCH] D26521: [X86] Allow folding of reloads from stack slots when loading a subreg of the spilled reg

[Matthias Braun via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

Thanks.

I wanted to propose to only perform the check in the `foldMemoryOperandImpl(MachineFunction &MF, MachineInstr &MI, unsigned OpNum,

  ArrayRef<MachineOperand> MOs, MachineBasicBlock::iterator InsertPt, unsigned Size, unsigned Align, bool AllowCommute)`

variant, as the other two finally call into that anyway. However I see a `MI.setDesc(get(NewOpc));` and I currently fail to reason about whether that common function may actually still abort after we changed the instruction type (soo much code I'm not that familiar with...).

So this LGTM as is.


https://reviews.llvm.org/D26521