[PATCH] D27008: [LoadStoreVectorizer] Enable vectorization of stores in the presence of an aliasing load
Justin Lebar via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 22 17:41:04 PST 2016
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
As we discussed, I want to try splitting out this loop into a load and a store version to see if it clarifies things, but I'm happy to do that as a separate patch. This lgtm.
================
Comment at: lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:535
+ // In the if condition, BarrierMemoryInstr will always dominate ChainInstr
+ // (the BarrierMemoryInstr is a store that precedes ChainInstr).
+ if (IsLoadChain && BarrierMemoryInstr)
----------------
I'd either get rid of the second paragraph here or encode it as an assert.
https://reviews.llvm.org/D27008
More information about the llvm-commits
mailing list