[PATCH] D26996: [StructurizeCFG] Add whitespace in getAnalysisUsage.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 13:46:30 PST 2016


jlebar created this revision.
jlebar added a reviewer: arsenm.
jlebar added a subscriber: llvm-commits.
Herald added a subscriber: wdng.

"addRequired" and "addPreserved" look very similar when squished up next
to each other -- without the newline this code looked to me like it was
addRequired'ing DominatorTreeWrapperPass twice.


https://reviews.llvm.org/D26996

Files:
  llvm/lib/Transforms/Scalar/StructurizeCFG.cpp


Index: llvm/lib/Transforms/Scalar/StructurizeCFG.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/StructurizeCFG.cpp
+++ llvm/lib/Transforms/Scalar/StructurizeCFG.cpp
@@ -257,6 +257,7 @@
     AU.addRequiredID(LowerSwitchID);
     AU.addRequired<DominatorTreeWrapperPass>();
     AU.addRequired<LoopInfoWrapperPass>();
+
     AU.addPreserved<DominatorTreeWrapperPass>();
     RegionPass::getAnalysisUsage(AU);
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26996.78940.patch
Type: text/x-patch
Size: 468 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161122/d82bb5fa/attachment.bin>


More information about the llvm-commits mailing list