[PATCH] D26987: Remove PDBFileBuilder::build() and related functions.

[Rui Ueyama via llvm-commits]

ruiu created this revision.
ruiu added a reviewer: zturner.
ruiu added a subscriber: llvm-commits.

PDBFileBuilder supports two different ways to create files.
One is PDBFileBuilder::commit. That function takes a filename
and write a result to the file. The other is PDBFileBuilder::build.
That returns a new PDBFile object.

This patch removes the latter because no one is using it and
in a real life situation we are very unlikely to need it.
Even if you need it, it'd be easy to write a new PDB to a memory
buffer and read it back.

Removing PDBFileBuilder::build enables us to remove other classes
build transitively.


https://reviews.llvm.org/D26987

Files:
  include/llvm/DebugInfo/PDB/Raw/DbiStreamBuilder.h
  include/llvm/DebugInfo/PDB/Raw/InfoStreamBuilder.h
  include/llvm/DebugInfo/PDB/Raw/PDBFileBuilder.h
  include/llvm/DebugInfo/PDB/Raw/TpiStreamBuilder.h
  lib/DebugInfo/PDB/Raw/DbiStreamBuilder.cpp
  lib/DebugInfo/PDB/Raw/InfoStreamBuilder.cpp
  lib/DebugInfo/PDB/Raw/PDBFileBuilder.cpp
  lib/DebugInfo/PDB/Raw/TpiStreamBuilder.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26987.78926.patch
Type: text/x-patch
Size: 6927 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161122/2ef88d3a/attachment.bin>