[PATCH] D26957: Fix for lost FastMathFlags in Reassociate optimization
Vyacheslav Klochkov via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 22 12:33:08 PST 2016
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287695: Fixed the lost FastMathFlags in Reassociate optimization. (authored by v_klochkov).
Changed prior to commit:
https://reviews.llvm.org/D26957?vs=78836&id=78925#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26957
Files:
llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
llvm/trunk/test/Transforms/Reassociate/propagate-flags.ll
Index: llvm/trunk/test/Transforms/Reassociate/propagate-flags.ll
===================================================================
--- llvm/trunk/test/Transforms/Reassociate/propagate-flags.ll
+++ llvm/trunk/test/Transforms/Reassociate/propagate-flags.ll
@@ -0,0 +1,14 @@
+; RUN: opt < %s -reassociate -S | FileCheck %s
+
+; CHECK-LABEL: func
+; CHECK: fmul fast double
+; CHECK-NEXT: fmul fast double
+; CHECK-NEXT: ret
+
+define double @func(double %a, double %b) {
+entry:
+ %mul1 = fmul fast double %a, %a
+ %mul2 = fmul fast double %b, %b
+ %mul3 = fmul fast double %mul1, %mul2
+ ret double %mul3
+}
Index: llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
+++ llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
@@ -1778,6 +1778,12 @@
return nullptr; // All distinct factors, so nothing left for us to do.
IRBuilder<> Builder(I);
+ // The reassociate transformation for FP operations is performed only
+ // if unsafe algebra is permitted by FastMathFlags. Propagate those flags
+ // to the newly generated operations.
+ if (auto FPI = dyn_cast<FPMathOperator>(I))
+ Builder.setFastMathFlags(FPI->getFastMathFlags());
+
Value *V = buildMinimalMultiplyDAG(Builder, Factors);
if (Ops.empty())
return V;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26957.78925.patch
Type: text/x-patch
Size: 1367 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161122/1658195c/attachment.bin>
More information about the llvm-commits
mailing list