[PATCH] D26982: Restructure DwarfDebug::beginInstruction (NFC).

[Paul Robinson via llvm-commits]

probinson marked an inline comment as done.
probinson added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1016-1037
+  if (DL) {
+    // We have a new, explicit location.
+    unsigned Flags = 0;
+    PrevInstLoc = DL;
+    if (DL == PrologEndLoc) {
+      Flags |= DWARF2_FLAG_PROLOGUE_END;
+      PrologEndLoc = DebugLoc();
----------------
dblaikie wrote:
> Would it help to reverse these two and early return from the UnknownLocations case - so the major "if (DL)" case could be non-indented? (but if the way you've got it works best for your other patch, that's cool)
Yes, thanks, it does help a bit.  That one is still the biggest case, even with the other patch.


https://reviews.llvm.org/D26982