[PATCH] D26781: [LSR] Canonicalize formula and put recursive Reg related with current loop in ScaledReg.

Wei Mi via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 11:01:01 PST 2016


wmi updated this revision to Diff 78896.
wmi added a comment.

Address Quentin's comments.

Suprising to me, I verified by running a bunch of tests and found that existing canonicalize calls already ensure all the formulas inserted are canonical so I don't have to add extra canonicalize calls.  It is indeed better than adding implicit canonicalization inside of InsertFormula. Thanks for the suggestion!


Repository:
  rL LLVM

https://reviews.llvm.org/D26781

Files:
  lib/Transforms/Scalar/LoopStrengthReduce.cpp
  test/Transforms/LoopStrengthReduce/X86/canonical.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D26781.78896.patch
Type: text/x-patch
Size: 14391 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161122/d1868756/attachment-0001.bin>


More information about the llvm-commits mailing list