[PATCH] D26879: Make a DwarfGen class that can generate DWARF for unittests and add units tests to test DWARF API.

[David Blaikie via llvm-commits]

Ah, thanks for explaining - perhaps we could get Fred and/or Adrian to take
a look at this, then?

Ideally we could split out the improvement (addressing the FIXME in the
code you quoted) reviewed and committed separately - then we'd have the
generic functionality you need for the unit testing API, and we could
review the unit testing API separately after that. It would be unfortunate
if the refactoring your doing for your use case didn't address the existing
use case/need already identified here - so it seems nice to motivate it by
that existing usage first.

You can probably just prototype (ensuring it passes the exsiting
llvm-dsymutil tests, etc) that in code review & Fred can take a quick look
ot sign off. But whatever order/way works best for you.

- Dave

On Tue, Nov 22, 2016 at 9:47 AM Greg Clayton <clayborg at gmail.com> wrote:

> clayborg added a comment.
>
> We actually don't need to modify the DwarfLinker, but I was planning on
> letting Fred Riss know that he can remove the code that works around a
> DIEEntry reference with DW_FORM_ref_addr after this was in. I didn't want
> to change the dwarf linker further to remove his work around without
> talking to him.
>
>
> https://reviews.llvm.org/D26879
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161122/422a3344/attachment.html>