[PATCH] D26659: [MemorySSA] Invoke the right getModRefInfo check in `instructionClobbersQuery` when UseLoc is passed.

Daniel Berlin via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 22 09:14:45 PST 2016


On Tue, Nov 22, 2016 at 8:59 AM, bryant <3.14472+reviews.llvm.org at gmail.com>
wrote:

> bryant added a comment.
>
> > Actually, can you please add a test for this before you commit?
> > You can use -print-memoryssa -analyze to get it to dump memoryssa.
> > If you need specific API calls, please add to the unit tests for
> MemorySSA.
>
> I'm having trouble getting `-analyze` to work:
>
>   16:58:24 ~/3rd/llvm/test> opt -print-memoryssa -analyze <
> Transforms/Util/MemorySSA/precision-call-clobbers.ll
>   ... # stuff
>   Printing analysis 'Memory SSA Printer' for function 'f':
>   Pass::print not implemented for pass: 'Memory SSA Printer'!



>
>
If the goal is to run FileCheck on the MemorySSA debug output, shouldn't
> -print-memoryssa alone be sufficient?
>
> It is now.
It did not used to be because MemorySSA was lazy, and when it was lazy,
-analyze was required to instantiate the result.


> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D26659
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161122/58478407/attachment.html>


More information about the llvm-commits mailing list