[PATCH] D26958: [ELF] Convert MIPS .rld_map to input section

[Rui Ueyama via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1663-1666
+  // Apply filler from linker script.
+  uint64_t Filler = Script<ELFT>::X->getFiller(this->Name);
+  Filler = (Filler << 32) | Filler;
+  Dummy = (uintX_t)Filler;
----------------
This should be moved to writeTo.


================
Comment at: ELF/SyntheticSections.h:606
+// ftp://www.linux-mips.org/pub/linux/mips/doc/ABI/mipsabi.pdf
+template <class ELFT> class MipsRldMap : public InputSection<ELFT> {
+  typedef typename ELFT::uint uintX_t;
----------------
Can you derive from SyntheticSection?


================
Comment at: ELF/SyntheticSections.h:613
+private:
+  uintX_t Dummy;
+};
----------------
You could just define `typename ELFT::uint Dummy;`.

But this is probably not a dummy because we actually need it. Maybe `Pad`?


Repository:
  rL LLVM

https://reviews.llvm.org/D26958