[PATCH] D26678: [X86] Remove dead code from LowerVectorBroadcast

[Zvi Rackover via llvm-commits]

zvi added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:5840
 /// or SDValue() otherwise.
 static SDValue LowerVectorBroadcast(SDValue Op, const X86Subtarget &Subtarget,
                                     SelectionDAG &DAG) {
----------------
andreadb wrote:
> Would it be possible to change this function so that 'Op' is a `BuildVectorSDNode` rather than a generic SDValue?
> The expicit cast at line 5859 would become redundant then.
> 
> It looks like this function is only used by method 'LowerBUILD_VECTOR' at around line 6646.
> 
Sure.


Repository:
  rL LLVM

https://reviews.llvm.org/D26678