[PATCH] D24854: [SROA] Drop lifetime.start/end intrinsics when they block promotion.

[Chandler Carruth via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D24854#602229, @vitalybuka wrote:

> If this patch can wait a couple of days I can investigate performance regression and amount of exposed false negatives.
>  It this is urgent then probably safe to do as suggested, with false-negatives, but without the risk of significant performance regression in Asan.


I would rather go ahead. The false negatives added will be small and rare compared to those we already have IMO. And I think the risk of performance regressions and other things is really quite high. Plus, it would need a great deal more testing than we currently have, mostly around cases which ASan should catch. This patch isn't really about ASan, so it seems better to unblock it and come back and do a comprehensive job with ASan in mind later.


Repository:
  rL LLVM

https://reviews.llvm.org/D24854