[PATCH] D26943: [CodingStandards] Add style guide rule about "if" statements and loops.

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 15:23:40 PST 2016


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM (though I would leave this open for a while until after the thanksgiving break to hear different opinions).

I would add an example. Maybe:

  if (SomethingIsOdd)
    return;
  
  if (CoolInstruction *CI = dyn_cast<CoolInstruction>(I)) {
    if (CI.IsBaz())
      ++BazInstructions;
  }


https://reviews.llvm.org/D26943





More information about the llvm-commits mailing list