[llvm] r287355 - [DebugInfo] Fix some Clang-tidy modernize-use-default, modernize-use-equal-delete and Include What You Use warnings; other minor fixes (NFC).

[Eugene Zelenko via llvm-commits]

On Mon, Nov 21, 2016 at 10:23 AM, David Blaikie <dblaikie at gmail.com> wrote:
>
>
> On Fri, Nov 18, 2016 at 10:10 AM Eugene Zelenko via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: eugenezelenko
>> Date: Fri Nov 18 12:00:19 2016
>> New Revision: 287355
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=287355&view=rev
>> Log:
>> [DebugInfo] Fix some Clang-tidy modernize-use-default,
>> modernize-use-equal-delete and Include What You Use warnings; other minor
>> fixes (NFC).
>>
>> Per Zachary Turner and Mehdi Amini suggestion to make only post-commit
>> reviews.
>>
>>
>> Modified:
>>     llvm/trunk/include/llvm/DebugInfo/CodeView/TypeTableBuilder.h
>>     llvm/trunk/include/llvm/DebugInfo/DIContext.h
>>     llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFContext.h
>>     llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
>>     llvm/trunk/include/llvm/DebugInfo/MSF/ByteStream.h
>>     llvm/trunk/include/llvm/DebugInfo/MSF/IMSFFile.h
>>     llvm/trunk/include/llvm/DebugInfo/MSF/SequencedItemStream.h
>>     llvm/trunk/include/llvm/DebugInfo/MSF/StreamArray.h
>>     llvm/trunk/include/llvm/DebugInfo/MSF/StreamInterface.h
>>     llvm/trunk/include/llvm/DebugInfo/MSF/StreamRef.h
>>     llvm/trunk/include/llvm/DebugInfo/MSF/StreamWriter.h
>>     llvm/trunk/include/llvm/DebugInfo/PDB/ConcreteSymbolEnumerator.h
>>     llvm/trunk/include/llvm/DebugInfo/PDB/IPDBEnumChildren.h
>>     llvm/trunk/include/llvm/DebugInfo/PDB/PDBContext.h
>>     llvm/trunk/include/llvm/DebugInfo/PDB/Raw/ISectionContribVisitor.h
>>     llvm/trunk/include/llvm/DebugInfo/PDB/Raw/ModInfo.h
>>     llvm/trunk/include/llvm/DebugInfo/PDB/Raw/TpiHashing.h
>>
>> - public:
>> -  DIInliningInfo() {}
>>
>> +
>> +public:
>> +  DIInliningInfo() = default;
>
>
> I'd just remove this ^ entirely, it's the implicit/default.

Yes, such statements could be removed, but probably will be good idea
to find why they were added. Probably with intention to expand, or may
be explicit statements made code more comprehensible?

>>  // entire size of the debug info sections.
>> -typedef DenseMap<uint64_t, std::pair<uint8_t, int64_t> > RelocAddrMap;
>> +typedef DenseMap<uint64_t, std::pair<uint8_t, int64_t>> RelocAddrMap;
>
>
> In the future, it's best not to reformat the whole file - use
> tools/clang/tools/clang-format/git-clang-format to only reformat the parts
> you change.

I didn't run Clang-fromat. I only fixed "> >".


Eugene.