[PATCH] D26892: [SCCP] Remove useless code in visitBinaryOperator (and add tests)
Davide Italiano via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 21 12:02:54 PST 2016
davide added a comment.
In https://reviews.llvm.org/D26892#601591, @efriedma wrote:
> LGTM.
Thanks Eli.
================
Comment at: lib/Transforms/Scalar/SCCP.cpp:932
+ if (NonOverdefVal->isUnknown())
return;
----------------
efriedma wrote:
> This is okay, I guess, but I don't think it fixes anything.
Yes, but it was just weird to have all that logic there.
https://reviews.llvm.org/D26892
More information about the llvm-commits
mailing list