[PATCH] D26880: [ThinLTO] Fix crash: transitively referenced global shouldn't be promoted

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D26880#601521, @tejohnson wrote:

> In https://reviews.llvm.org/D26880#601477, @mehdi_amini wrote:
>
> >
>
>
> I normally would agree, except that this is an optimization that has been in for awhile, and maintaining it has a simple fix (the patch I sent last night should do it), until we have the longer term enhancement in.


Right, but that's two separate discussions IMO: 1) the correctness fix, 2) adding a `temporary` and `well scoped` optimization patch waiting for a better solution (and a test-case will be needed).


https://reviews.llvm.org/D26880