[PATCH] D26224: NewGVN

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 21 04:52:59 PST 2016


jmolloy added a comment.

Hi Davide,

A high level comment for an issue I've just run into when rebasing GVNSink on top of NewGVN - you've defined LoadExpression::equals and StoreExpression::equals in the header, which gives multiple definition errors (for ::equals and the vtables) if any other file tries to #include <GVNExpression.h>.

Cheers,

James


https://reviews.llvm.org/D26224





More information about the llvm-commits mailing list