[PATCH] D26877: Minor fixes in Loop Strength Reduction

[Hal Finkel via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopStrengthReduce.cpp:4149
         Best = Reg;
-      else {
+        BestNum = RegUses.getUsedByIndices(Reg).count();
+      } else {
----------------
evstupac wrote:
> hfinkel wrote:
> > Do you have a test case for this change?
> > 
> > If/When you commit this, it should be separate from the other changes.
> No. I don't. I can try to create.
> However, it looks like a misprint in MAX search algorithm. We are always missing the case when first Reg in RegUses has the biggest RegUses.getUsedByIndices(...).count().
> 
Okay; makes sense to me.


Repository:
  rL LLVM

https://reviews.llvm.org/D26877