[PATCH] D26888: [ELF] - Implemented -N, --norosegment flags.

[Brad Smith via llvm-commits]

brad added inline comments.


================
Comment at: ELF/Writer.cpp:1110-1112
 // Decide which program headers to create and which sections to include in each
 // one.
 template <class ELFT> std::vector<PhdrEntry<ELFT>> Writer<ELFT>::createPhdrs() {
----------------
grimar wrote:
> ruiu wrote:
> > I really don't want to mess up this function more than this. It's already complicated. Do you really need -N?
> I am still digging the FreeBSD stuff here, as far I know they tried to use linkerscript instead but had to revert the change as it was buggy for them. From what I know it is a desired feature to have anyways at least for now.
> Ed might tell more I think, as I mentioned, I am still investigating that all.
> 
We need -N for OpenBSD's boot blocks/loaders as well.


https://reviews.llvm.org/D26888