[PATCH] D26880: [ThinLTO] Fix crash: transitively referenced global shouldn't be promoted

[Mehdi AMINI via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D26880#600909, @tejohnson wrote:

> In https://reviews.llvm.org/D26880#600745, @mehdi_amini wrote:
>
> > So my current feeling is:
> >
> > - the fix for PR31052 is to disable the "magic" in IRLinker that import definition we didn't ask for.
>
>
> The IRLinker shouldn't be changed - it would be removing the constant unnamed_addr handling from doPromoteLocalToGlobal. The IRLinker does the right thing based on the linkage.


I don't get this part? 
I expect the imported to *control* what is imported, and nothing that isn't marked for import should be imported.


https://reviews.llvm.org/D26880