[PATCH] D26892: [SCCP] Remove useless code in visitBinaryOperator (and add tests)

[Davide Italiano via llvm-commits]

davide added inline comments.


================
Comment at: lib/Transforms/Scalar/SCCP.cpp:932
+      if (NonOverdefVal->isUnknown())
         return;
 
----------------
efriedma wrote:
> This is okay, I guess, but I don't think it fixes anything.
Yes, but it was just weird to have all that logic there.


================
Comment at: lib/Transforms/Scalar/SCCP.cpp:932
+      if (NonOverdefVal->isUnknown())
         return;
 
----------------
efriedma wrote:
> This is okay, I guess, but I don't think it fixes anything.
Renamed the revision accordingly


https://reviews.llvm.org/D26892