[PATCH] D26890: SHA1: unroll loop in hashBlock.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 19 16:53:53 PST 2016


ruiu added inline comments.


================
Comment at: lib/Support/SHA1.cpp:82
+  B = rol(B, 30);
+}
+
----------------
mehdi_amini wrote:
> Please use static free function if there is no need to access the state of the object.
blk and blk0 access InternalState, so these functions need to be members.


https://reviews.llvm.org/D26890





More information about the llvm-commits mailing list