[PATCH] D26890: SHA1: unroll loop in hashBlock.

[Mehdi AMINI via llvm-commits]

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LGTM, Thanks!

In https://reviews.llvm.org/D26890#600802, @ruiu wrote:

> If I do not unroll the loop, computing a hash on a file worsened from 4.16 seconds to 5.77, so there's definitely an impact.


Please file a PR on llvm.org with the non-unrolled version of this code, and CC me. The optimization folks should look at this!



================
Comment at: lib/Support/SHA1.cpp:82
+  B = rol(B, 30);
+}
+
----------------
Please use static free function if there is no need to access the state of the object.


https://reviews.llvm.org/D26890