[llvm] r287355 - [DebugInfo] Fix some Clang-tidy modernize-use-default, modernize-use-equal-delete and Include What You Use warnings; other minor fixes (NFC).

Eugene Zelenko via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 19 12:33:04 PST 2016


Hi, Malcolm!

On Sat, Nov 19, 2016 at 12:27 PM, Malcolm Parsons
<malcolm.parsons at gmail.com> wrote:
> On 18 November 2016 at 18:00, Eugene Zelenko via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> -  virtual ~WritableStream() {}
>> +  ~WritableStream() override = default;
>
> This declaration does nothing.
> Should clang-tidy remove it?
>
> --
> Malcolm Parsons

I suggested such check awhile ago: https://llvm.org/bugs/show_bug.cgi?id=22872.

Eugene.


More information about the llvm-commits mailing list