[PATCH] D26880: [ThinLTO] Fix crash: transitively referenced global shouldn't be promoted

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 19 10:47:11 PST 2016


mehdi_amini added a comment.

So my current feeling is:

- the fix for PR31052 is to disable the "magic" in IRLinker that import definition we didn't ask for.
- let this patch go
- work on the importing logic to start considering "refs" to be imported when possible / profitable (i.e. catch the performance gain we hope to have with PR31052)


https://reviews.llvm.org/D26880





More information about the llvm-commits mailing list